Conversation
external/CMakeLists.txt unconditionally ran FetchContent for GoogleTest during CMake configure, regardless of DLAF_BUILD_TESTING. Wrap the fetch in if(DLAF_BUILD_TESTING) so library-only configures (-DDLAF_BUILD_TESTING=OFF) don't clone and configure GoogleTest for nothing. Closes eth-cscs#26.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
external/CMakeLists.txtwas unconditionally runningFetchContent_Declare/FetchContent_MakeAvailablefor GoogleTest during CMake configure, regardless of whether tests were going to be built. This meant every configure (including-DDLAF_BUILD_TESTING=OFFbuilds, e.g. library-only installs) cloned GoogleTest from GitHub and configured it, even though nothing would ever use it.Change: wrap the GoogleTest
FetchContentblock inif(DLAF_BUILD_TESTING) ... endif(), matching the existing option already used to gateadd_subdirectory(test)in the top-levelCMakeLists.txt.Verified locally (isolated CMake harness, since I don't have the full DLAF dependency stack available):
-DDLAF_BUILD_TESTING=OFF: configure completes, no_deps/googletest-*directories are created.-DDLAF_BUILD_TESTING=ON: configure completes and GoogleTest is fetched/configured exactly as before (_deps/googletest-src,-build,-subbuildall present).