perf(sdk): pipeline EOAWallet.sendBatch receipt waits#507
Draft
its-everdred wants to merge 5 commits into
Draft
Conversation
✅ Deploy Preview for actions-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #456
Problem
EOAWallet.sendBatchpreviously sent a transaction, waited for its receipt, then moved to the next transaction. That kept ordered batches safe, but it also serialized the slow part of the flow: a cold-path swap with approval, Permit2 approval, and swap had to wait roughly one block per transaction before the next one could even be submitted. Fully parallel broadcasts are not a safe replacement because viem's nonce manager guarantees unique nonces, not that racing sends consume nonces in array order, so an ordered batch could assign the swap nonce before its approval nonce.Solution