Add builder_pending_withdrawals and builder_pending_payments endpoints - #655
markolazic01 wants to merge 2 commits into
Conversation
| | [#655](https://github.com/ethereum/beacon-APIs/pull/655) `GET /eth/v1/beacon/states/{state_id}/builder_pending_withdrawals` added | | | | | | | ||
| | [#655](https://github.com/ethereum/beacon-APIs/pull/655) `GET /eth/v1/beacon/states/{state_id}/builder_pending_payments` added | | | | | | |
There was a problem hiding this comment.
I am gonna sort the changelog before the release but we should add entries to the bottom, sorted by pr number but it's always a bit annoying right now with merge conflicts, so keeping it here now it fine
There was a problem hiding this comment.
got it, I was not sure if I should put them to the top or the bottom
There was a problem hiding this comment.
after the release can explore #579 or other solutions, ideally we want a solution that is easy to understand for someone that puts up a pr and also doesn't cause merge conflicts between prs
There was a problem hiding this comment.
I saw that one, I can spend some time on that if you'd like.
There was a problem hiding this comment.
rather low prio right now, we can resolve this after the release
| /eth/v1/beacon/states/{state_id}/builder_pending_withdrawals: | ||
| $ref: "./apis/beacon/states/builder_pending_withdrawals.yaml" | ||
| /eth/v1/beacon/states/{state_id}/builder_pending_payments: | ||
| $ref: "./apis/beacon/states/builder_pending_payments.yaml" |
There was a problem hiding this comment.
Do we want to add Gloas.BuilderPendingPayment and Gloas.BuilderPendingWithdrawal under components: schema:?
(some lines below in this same file)
I see that previous PR added the type in the components and schema section, for example: https://github.com/ethereum/beacon-APIs/pull/512/files#diff-962ea34dc6ec0e65d4e1d6c8682e97c547e6e0d2f1168925210ff7ee47ef6ce0R437-R438
Motivation
Make a staked builder's unsettled payments accessible to the builder and external viewers.
Description
Closes #636
Adds two endpoints to read the Gloas builder payment fields from a given state:
GET /eth/v1/beacon/states/{state_id}/builder_pending_withdrawalsGET /eth/v1/beacon/states/{state_id}/builder_pending_paymentsBoth return the state field as is, following the
pending_*andproposer_lookaheadendpoints, with JSON and SSZ responses and a 400 for pre-Gloas states. The item typesBuilderPendingWithdrawalandBuilderPendingPaymentalready exist intypes/gloas/builder.yamland remain unchanged.