Repository navigation
feat(cli): scripted unlock, ~/.edw data dir, clean stdout, exit codes - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106. Supersedes #112.
balance --verboseis nowbalance --detailed, so-v/--verbosemeans more logging on every command.~/.edwfrom any folder. It used to be./.edwunder the current directory, so each folder had its own wallet. The variable is renamed fromDATA_DIRtoEDW_DATA_DIRso it doesn't clash with other tools. Existing users: move./.edwto~/.edwor pass--data-dir ./.edw.--non-interactive, or with stdin piped as in a script or CI) used to fail unlessedw unlockhad left a session. Now it can read the password fromEDW_DECRYPTION_PASSWORD.edw unlock --non-interactiveand every command without a terminal used to fail. Now unlock succeeds and reports that no session was kept, and commands readEDW_DECRYPTION_PASSWORD. Sessions on macOS are EDW-030 - Keep the unlock session in memory #116.edw lock. Now that session is dropped and the wallet counts as locked.--non-interactiveJSON. Now they go to stderr atwarn, adjustable with-vand-q.--non-interactivefailures are JSON. They used to be plainError:text on stderr; now they're oneedw/errordocument on stdout, parsed like any other result.edw config viewshows where you are. It now lists the networks that exist, the active RPC, and where a session is held, and works while locked.--helplists only working commands.network status,database migrateanddatabase purgeonly errored; they're hidden.XDG_RUNTIME_DIRused to put the session in./edw,edw locksaid "nothing to do" when the store couldn't be opened, and a failed unlock could leave the previous network unlocked while saying otherwise.