Respect setMessageOwnersToServiceOwners option in OpenAPI generator#427
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 40b945b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves event-catalog/eventcatalog#2721
What This PR Does
Fixes the
setMessageOwnersToServiceOwnersservice option in the OpenAPI generator. The option was effectively ignored (always evaluating totrue) and was also being written onto the generated service object as an unexpected property. It now defaults totrue, correctly honoursfalse, and no longer leaks into the service.Changes Overview
Key Changes
setMessageOwnersToServiceOwnersonto the built service object inutils/services.ts(the|| truefallback made it alwaystrue).index.tswith a proper?? truedefault and use it to decide whether service owners are applied to messages.false, service owners are not added to messages.How It Works
Previously
buildServicesetsetMessageOwnersToServiceOwners: serviceOptions.setMessageOwnersToServiceOwners || true, which always resolved totrueand persisted the flag on the service. The generator then read it back off the service. The logic now resolves the option once inindex.ts(serviceSpec.setMessageOwnersToServiceOwners ?? true) and passes the resulting owners list to message processing, keeping the flag out of the service model entirely.Breaking Changes
None.
Additional Notes
Tests were not run as part of this change per request.