Repository navigation
Avoid redundant awaits for request-only delegate handlers - #70
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 38 38
Lines 1571 1573 +2
Branches 286 287 +1
=======================================
+ Hits 1522 1524 +2
+ Misses 20 19 -1
- Partials 29 30 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request-only delegate handlers without injected services currently add an async wrapper even though they have no response validation or scope disposal to perform. Return the invoker's original ValueTask directly on that path; the consumer still awaits actual completion before completing requests and releasing the execution slot.
Keep response validation, service scope disposal, and initial expression compilation intact. Add completion and concurrency regression tests, mixed-submission stress coverage, reusable benchmarks, and the measured before/after results.
Emphasize in the English, Chinese, and NuGet READMEs that every response entry must be assigned exactly once. Missing assignments fail the whole Handler batch; an explicitly assigned null is a valid nullable response.
Validation: