Expression Support#215
Open
hfytr wants to merge 6 commits into
Open
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Please run: julia --project=@runic -e 'using Pkg; Pkg.add("Runic")'
julia --project=@runic -e "using Runic; exit(Runic.main(ARGS))" -- --fix <files>(or Note: the full diff is omitted because it can exceed GitHub Actions input limits. |
Member
|
@hfytr The diff is very big and hard to review. Can you update the PR to only keep the modifications related to expression support? |
Member
|
@hfytr I think you used runic on all files. Let me know if you need help with this. |
Collaborator
Author
|
Hello michel. That’s correct. I’m traveling, but expect code by Tuesday / Wednesday. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…string quotes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ext/ExaModelsKernelAbstractions.jl: update all kernel calls from AdjointNodeSource(x)/SecondAdjointNodeSource(x) to the two-argument form AdjointNodeSource(x, nothing)/SecondAdjointNodeSource(x, nothing) now required after PR exanauts#215 added the offset_exps field - src/nlp.jl: add missing `pars = gen.iter` in add_con! (3-arg form) before the call to _add_con!, fixing UndefVarError at line 1199 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
PR exanauts#215 added e/e_starts/e_cnts params to jrpass and e/e_starts/e_cnts/e2/e2_starts/e2_cnts params to hrpass0/hrpass, but the KernelAbstractions kernels were not updated. Pass nothing for all expression-cache args since GPU kernels don't use the expression cache. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Update direct low-level calls in ADTest to match new signatures: - AdjointNodeSource/SecondAdjointNodeSource: add second arg `nothing` - sgradient!: add isexp=nothing as 9th arg (was 8-arg, now 9-arg) - sjacobian!: restructure to 14-arg form (isexp, y1, y2, f, e, e_starts, e_cnts, p, x, θ, comp, o0, o1, adj) - hrpass0: prepend 6 nothing args (e, e_starts, e_cnts, e2, e2_starts, e2_cnts) to match new 14-arg form Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…st_nlp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 80.80% 0.00% -80.81%
==========================================
Files 20 26 +6
Lines 2021 3190 +1169
==========================================
- Hits 1633 0 -1633
- Misses 388 3190 +2802 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes expressions to no longer re-evaluate on every reference, and instead pre-computes once for every call to jac_coord / hess_coord / etc.