fix: logError now logs the full error object (cause, parent, original)#7311
Closed
neocrev wants to merge 1 commit into
Closed
fix: logError now logs the full error object (cause, parent, original)#7311neocrev wants to merge 1 commit into
neocrev wants to merge 1 commit into
Conversation
… properties Using console.error(err.stack || err.toString()) drops Error.cause, Sequelize parent/original, and other custom properties. console.error(err) logs the complete error object including nested details. Fixes #6462
Contributor
|
Duplicate of #6464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6462
Problem
The
logErrorfunction currently uses:This drops all custom error properties that are not part of the stack trace, including:
Error.cause(nested errors)parentandoriginalpropertiesFix
Changed to:
console.error()already prints the stack trace for Error objects, and additionally includes all enumerable properties (cause, parent, original, etc.). This is the standard recommended approach in Node.js and matches how logging libraries handle errors.Verification
console.error(new Error("outer", { cause: new Error("inner") }))prints the full error withcauseparentandoriginalproperties in the logCloses #6462