This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Handle multiple config maps correctly #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple config maps were given in the annotation the controller would set the environment variables for _all_ config maps to the token-ed value of the last updated config map, leading to considerably more updates than needed (and a very confusing list of environment variables)
Author
|
Actually ... this is a duplicate of #17. @jstrachan, could you merge one of these please? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple config maps were given in the annotation the controller would set the environment variables
for all config maps to the token-ed value of the last updated config map, leading to considerably more
updates than needed (and a very confusing list of environment variables)