rename parallelism=>concurrency across all of Ax#4861
Closed
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
Closed
rename parallelism=>concurrency across all of Ax#4861mgrange1998 wants to merge 1 commit intofacebook:mainfrom
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92457714. |
41bb89f to
eab1b83
Compare
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 20, 2026
…tch_utils (facebook#4861) Summary: Renames the `max_parallelism` parameter to `max_concurrency` across GenerationStep, GenerationNode, and the generation strategy dispatch utilities. Adds backward-compatible deprecated `max_parallelism` parameters with deprecation warnings where the public API is affected (`choose_generation_strategy`). Internal variable names (`sobol_parallelism`, `bo_parallelism`) are renamed to `sobol_concurrency`, `bo_concurrency` for consistency. Differential Revision: D92457714
eab1b83 to
f19e837
Compare
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 20, 2026
…tch_utils (facebook#4861) Summary: Renames the `max_parallelism` parameter to `max_concurrency` across GenerationStep, GenerationNode, and the generation strategy dispatch utilities. Adds backward-compatible deprecated `max_parallelism` parameters with deprecation warnings where the public API is affected (`choose_generation_strategy`). Internal variable names (`sobol_parallelism`, `bo_parallelism`) are renamed to `sobol_concurrency`, `bo_concurrency` for consistency. Differential Revision: D92457714
f19e837 to
77102b6
Compare
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 20, 2026
…in dispatch_utils and generation_node (facebook#4861) Summary: Renames internal variables, constants, and terminology from "parallelism" to "concurrency" in the generation strategy dispatch utilities and generation node. Public API parameter names (`max_parallelism` in `GenerationStep`, `max_parallelism_cap`/`max_parallelism_override` in `choose_generation_strategy_legacy`) are intentionally preserved to avoid breaking changes. Changes: - Constant: `DEFAULT_BAYESIAN_PARALLELISM` → `DEFAULT_BAYESIAN_CONCURRENCY` - Private helper params in `_make_sobol_step` / `_make_botorch_step`: `max_parallelism` → `max_concurrency` - Internal variables: `sobol_parallelism` / `bo_parallelism` → `sobol_concurrency` / `bo_concurrency` - Docstrings, comments, and error messages updated to use "concurrency" terminology - Test helpers and test names updated to match - `automl/internal/ax/utils/constants.py` re-exports under old name for backward compatibility - `ax/service/tests/test_ax_client.py` updated to use new constant name Differential Revision: D92457714
77102b6 to
d2633c0
Compare
…in dispatch_utils and generation_node (facebook#4861) Summary: Renames internal variables, constants, and terminology from "parallelism" to "concurrency" in dispatch_utils and generation_node. Public API parameter names (`max_parallelism`, `max_parallelism_cap`, `max_parallelism_override`) are preserved to avoid breaking changes. - `DEFAULT_BAYESIAN_PARALLELISM` → `DEFAULT_BAYESIAN_CONCURRENCY`; internal variables and private helper params renamed similarly - Docstrings, comments, error messages, and test names updated to match - `automl/internal/ax/utils/constants.py` re-exports under old name for backward compatibility Differential Revision: D92457714
d2633c0 to
bd8c115
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4861 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 595 595
Lines 63160 63160
=======================================
+ Hits 61135 61136 +1
+ Misses 2025 2024 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in cf057df. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D92457714