Skip to content

Comments

rename parallelism=>concurrency across all of Ax#4861

Closed
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
mgrange1998:export-D92457714
Closed

rename parallelism=>concurrency across all of Ax#4861
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
mgrange1998:export-D92457714

Conversation

@mgrange1998
Copy link
Contributor

Differential Revision: D92457714

@meta-codesync
Copy link

meta-codesync bot commented Feb 6, 2026

@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92457714.

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 6, 2026
mgrange1998 added a commit to mgrange1998/Ax that referenced this pull request Feb 20, 2026
…tch_utils (facebook#4861)

Summary:

Renames the `max_parallelism` parameter to `max_concurrency` across GenerationStep, GenerationNode, and the generation strategy dispatch utilities. Adds backward-compatible deprecated `max_parallelism` parameters with deprecation warnings where the public API is affected (`choose_generation_strategy`). Internal variable names (`sobol_parallelism`, `bo_parallelism`) are renamed to `sobol_concurrency`, `bo_concurrency` for consistency.

Differential Revision: D92457714
mgrange1998 added a commit to mgrange1998/Ax that referenced this pull request Feb 20, 2026
…tch_utils (facebook#4861)

Summary:

Renames the `max_parallelism` parameter to `max_concurrency` across GenerationStep, GenerationNode, and the generation strategy dispatch utilities. Adds backward-compatible deprecated `max_parallelism` parameters with deprecation warnings where the public API is affected (`choose_generation_strategy`). Internal variable names (`sobol_parallelism`, `bo_parallelism`) are renamed to `sobol_concurrency`, `bo_concurrency` for consistency.

Differential Revision: D92457714
mgrange1998 added a commit to mgrange1998/Ax that referenced this pull request Feb 20, 2026
…in dispatch_utils and generation_node (facebook#4861)

Summary:

Renames internal variables, constants, and terminology from "parallelism" to "concurrency" in the generation strategy dispatch utilities and generation node. Public API parameter names (`max_parallelism` in `GenerationStep`, `max_parallelism_cap`/`max_parallelism_override` in `choose_generation_strategy_legacy`) are intentionally preserved to avoid breaking changes.

Changes:
- Constant: `DEFAULT_BAYESIAN_PARALLELISM` → `DEFAULT_BAYESIAN_CONCURRENCY`
- Private helper params in `_make_sobol_step` / `_make_botorch_step`: `max_parallelism` → `max_concurrency`
- Internal variables: `sobol_parallelism` / `bo_parallelism` → `sobol_concurrency` / `bo_concurrency`
- Docstrings, comments, and error messages updated to use "concurrency" terminology
- Test helpers and test names updated to match
- `automl/internal/ax/utils/constants.py` re-exports under old name for backward compatibility
- `ax/service/tests/test_ax_client.py` updated to use new constant name

Differential Revision: D92457714
…in dispatch_utils and generation_node (facebook#4861)

Summary:

Renames internal variables, constants, and terminology from "parallelism" to "concurrency" in dispatch_utils and generation_node. Public API parameter names (`max_parallelism`, `max_parallelism_cap`, `max_parallelism_override`) are preserved to avoid breaking changes.

- `DEFAULT_BAYESIAN_PARALLELISM` → `DEFAULT_BAYESIAN_CONCURRENCY`; internal variables and private helper params renamed similarly
- Docstrings, comments, error messages, and test names updated to match
- `automl/internal/ax/utils/constants.py` re-exports under old name for backward compatibility

Differential Revision: D92457714
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.79%. Comparing base (1e7a289) to head (bd8c115).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4861   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         595      595           
  Lines       63160    63160           
=======================================
+ Hits        61135    61136    +1     
+ Misses       2025     2024    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meta-codesync meta-codesync bot closed this in cf057df Feb 23, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 23, 2026

This pull request has been merged in cf057df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants