[Cisco][G200] SRv6 validation fixes#1002
Open
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
This change updates SRv6 encap tests to: TTL mode: Use UNIFORM instead of PIPE in makeSrv6TunnelConfig() so the outer IPv6 hop limit is decremented by 1 (uniform as the inner pkt). DSCP check: Add a check that the outer header traffic class copies the inner DSCP (upper 6 bits), using EXPECT_EQ(v6Hdr.trafficClass >> 2, kTc). Signed-off-by: Khiruthigai (Kitty) Balasubramanian <khbalasu@khbalasu-dev1.cisco.com>
itskittycisco
changed the title
itskittycisco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates SRv6 encap tests to:
TTL mode: Use UNIFORM instead of PIPE in makeSrv6TunnelConfig() so the outer IPv6 hop limit is decremented by 1 (uniform as the inner pkt).
DSCP check: Add a check that the outer header traffic class copies the inner DSCP (upper 6 bits), using EXPECT_EQ(v6Hdr.trafficClass >> 2, kTc).
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.............................................................Passed
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Summary
Test Plan