[Nexthop] Don't fail dnf when mirrors are unreachable#1006
Open
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
[Nexthop] Don't fail dnf when mirrors are unreachable#1006travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
During early boot or in some lab scenarios there is no external network connectivity and querying external RPM mirror will fail. By default CentOS treats this as a fatal failure and will refuse to continue dnf processing, even if the necessary packages are available in an RPM repo which can be accessed. This is a problem because platform_manager uses dnf to install the BSP RPM which comes from the local_rpm_repo. We need this to succeed to have a usable system where platform_manager and therefore the FBOSS agents and services come up. This change makes all RPM repos optional so a failure to connect will not cancel dnf operations. Thus platform_manager will succeed in installing the BSP RPM even when there is no external connectivity. This was tested as a fresh install on a dut installed in an isolated network where there is no external network access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
During early boot or in some lab scenarios there is no external network connectivity and querying external RPM mirror will fail. By default CentOS treats this as a fatal failure and will refuse to continue dnf processing, even if the necessary packages are available in an RPM repo which can be accessed.
This is a problem because platform_manager uses dnf to install the BSP RPM which comes from the local_rpm_repo. We need this to succeed to have a usable system where platform_manager and therefore the FBOSS agents and services come up.
This change makes all RPM repos optional so a failure to connect will not cancel dnf operations. Thus platform_manager will succeed in installing the BSP RPM even when there is no external connectivity.
Test Plan
This was tested as a fresh install on a dut installed in an isolated network where there is no external network access.