[Cisco][G200] Srv6 link flap test case fixes#1009
Open
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Open
[Cisco][G200] Srv6 link flap test case fixes#1009itskittycisco wants to merge 1 commit intofacebook:mainfrom
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Conversation
1. On LAG member link down, FBOSS sets `EGRESS_DISABLE=true` via SAI. On link up, nothing re-enables the member. For static LAGs (no LACP), the flapped port stays disabled and traffic fails. Fix is to Re-enable LAG members on link up in the fast path, and unresolve neighbors before re-resolve in the SRv6 encap link-flap test so SW state matches SAI. 2. In `sendPacketToEncapRouteAfterLinkFlap`, unresolve the neighbors for the flapped port before re-resolve. Agent-test uses NeighborUpdaterNoopImpl, so purge never updated SW state on link down; unresolving ensures SW state matches SAI before re-resolving next hops.
itskittycisco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EGRESS_DISABLE=truevia SAI for SAI_LAG_MEMBER_ATTR_EGRESS_DISABLE. On link up, nothing re-enables the member. For static LAGs (no LACP), the flapped port stays disabled and traffic fails. Fix is to Re-enable LAG members on link up.sendPacketToEncapRouteAfterLinkFlap, unresolve the neighbors for the flapped port before re-resolve. Agent-test uses NeighborUpdaterNoopImpl, so purge never updated SW state on link down; unresolving ensures SW state matches SAI before re-resolving next hops.Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.............................................................Passed
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Summary
Test Plan