Add StableRadixSort improvements and hybrid_vector container#2662
Open
LinnJz wants to merge 1 commit into
Open
Add StableRadixSort improvements and hybrid_vector container#2662LinnJz wants to merge 1 commit into
LinnJz wants to merge 1 commit into
Conversation
bd1547c to
1cea4d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes StableRadixSort and introduces hybrid_vector (with
HybridAlloc) to support its runtime-sized bucket allocations.
StableRadixSort
offering four combined modes
handling, NaN positioning)
hybrid_vector & HybridAlloc
storage (threshold configurable, default 1024 bytes)
storage. The number of threads is runtime-known, so stack-only allocation
(alloca) isn't viable directly. BitsPerPass::Bits8 (256 entries) fits stack;
Bits16 (65536 entries) requires heap. hybrid_vector provides a unified
abstraction that auto-selects the backing storage.
Additional