Open
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
This does have the trade-off that EMFILEs in `_processSourceRequest` in `metro/src/Server.js` won't be retried anymore. This is probably a fair trade-off since the EMFILE issue isn't handled elsewhere.
kitten
force-pushed
the
@kitten/refactor/metro-file-map/drop-graceful-fs-and-simplify
branch
from
c3eb777 to
a56223f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note: This PR is a proposal, but if there's existing/known issues with works around re.
EMFILEthen it'll likely need further changes.This removes
graceful-fswhich doesn't seem to see much use in the codebase anymore and is only being used in a handful of places.Dropping it in the Node crawler in
metro-file-mapdoesn't seem to have an observable effect. The amount of file handles in this phase should be limited, and it doesn't seem to do us much good to limit this further. If needed, we could limit the amount ofreaddircalls that are run in parallel instead.Dropping it in
metroitself means that_processSourceRequestwon't retry internally onEMFILEerrors. However, as this also isn't done elsewhere andgraceful-fsis only used for the singlecreateReadStreamcall here, it doesn't seem to be crucial to keep.Changelog: [Internal] Remove
graceful-fsTest plan