refactor: Tweak metro-resolver's Node module resolution hot-path

[kitten]

Summary

The current implementation in resolve.js seems slightly optimised for readability over performance, but is a hot-path that is highly impactful for bundling performance. This is slightly amplified depending on the depth of folders.

This branch aims to:

• eliminate redundant fileSystem.lookup and instead resolve immediately and return the earliest result
• avoid redundant array allocations and instead iterate target paths directly
• delay building a full array of target nodeModulesPaths when a FailedToResolveNameError is constructed

While this interleaves the actual resolution, avoiding redundant work and allocations makes up for this.

A very primitive (LLM-authored) benchmark can be found here, which shows an up to 10% benefit or neutral results for resolution: kitten@a36d558

Changelog: [Internal] Refactor performance sensitive metro-resolver Node module resolution hot path

Test plan

• CI tests should pass unchanged

[robhogan]

Nice 👌

[meta-codesync]

@robhogan has imported this pull request. If you are a Meta employee, you can view this in D100149182.

[robhogan]

optimised for readability over performance

That's very charitable 😅