-
Notifications
You must be signed in to change notification settings - Fork 25k
Align default transform profile Babel preset with legacy Hermes - drop "older" engines #54806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
…p "older" engines (#54806) Summary: Align the default transform profile in our Babel preset with the current state of `hermes-stable`, drop non-Hermes, pre-ES6 engines which have been unsupported in core since the JSC removal. This will allow us to subsequently repurpose transform profiles (`unstable_transformProfile`) to remove transforms unnecessary for Hermes v1 (aka Static Hermes) as follows: - `hermes-canary` -> Hermes v1 (experimental features) - `hermes-stable` -> Hermes v1 - Default -> All supported engines (i.e, Hermes v1 and legacy) Changelog: [General][Removed] Remove Babel preset transforms for already-unsupported non-Hermes engines Reviewed By: javache, huntie Differential Revision: D88269506
fb89829 to
ac5957d
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
…p "older" engines (#54806) Summary: Align the default transform profile in our Babel preset with the current state of `hermes-stable`, drop non-Hermes, pre-ES6 engines which have been unsupported in core since the JSC removal. This will allow us to subsequently repurpose transform profiles (`unstable_transformProfile`) to remove transforms unnecessary for Hermes v1 (aka Static Hermes) as follows: - `hermes-canary` -> Hermes v1 (experimental features) - `hermes-stable` -> Hermes v1 - Default -> All supported engines (i.e, Hermes v1 and legacy) Changelog: [General][Removed] Remove Babel preset transforms for already-unsupported non-Hermes engines Reviewed By: javache, huntie Differential Revision: D88269506
ac5957d to
f70709d
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
…p "older" engines (#54806) Summary: Align the default transform profile in our Babel preset with the current state of `hermes-stable`, drop non-Hermes, pre-ES6 engines which have been unsupported in core since the JSC removal. This will allow us to subsequently repurpose transform profiles (`unstable_transformProfile`) to remove transforms unnecessary for Hermes v1 (aka Static Hermes) as follows: - `hermes-canary` -> Hermes v1 (experimental features) - `hermes-stable` -> Hermes v1 - Default -> All supported engines (i.e, Hermes v1 and legacy) Changelog: [General][Removed] Remove Babel preset transforms for already-unsupported non-Hermes engines Reviewed By: javache, huntie Differential Revision: D88269506
f70709d to
7b38928
Compare
|
This pull request has been merged in 07bd24e. |
Collaborator
|
This pull request was successfully merged by @robhogan in 07bd24e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Align the default transform profile in our Babel preset with the current state of
hermes-stable, drop non-Hermes, pre-ES6 engines which have been unsupported in core since the JSC removal.This will allow us to subsequently repurpose transform profiles (
unstable_transformProfile) to remove transforms unnecessary for Hermes v1 (aka Static Hermes) as follows:hermes-canary-> Hermes v1 (experimental features)hermes-stable-> Hermes v1Changelog:
[General][Removed] Remove Babel preset transforms for already-unsupported non-Hermes engines
Reviewed By: huntie
Differential Revision: D88269506