Add ThemePreferences listener for dark mode updates #54808
Closed
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…facebook#54791) Summary: This change adds a listener mechanism to the `OverrideColorScheme` interface to enable dynamic updates when the user's dark mode preference changes via `OverrideColorScheme`. Previously, `AppearanceModule` would only reflect the initial color scheme state when instantiated. If a user toggled dark mode through an `OverrideColorScheme` implementation, React Native JavaScript would not be notified of the change, causing UI inconsistencies. This implementation adds: 1. An optional `addSchemeChangeListener()` method to the `OverrideColorScheme` interface with a default no-op implementation for backward compatibility. Also adding matching `removeSchemeChangeListener()`. 2. Automatic listener registration in `AppearanceModule`'s init block that triggers `onConfigurationChanged()` when the color scheme changes Changelog: [Android][Added] - Add `addSchemeChangeListener()` function to `OverrideColorScheme` interface to support dynamic appearance updates via override Reviewed By: javache Differential Revision: D88427482
Summary: This change implements the internal Facebook-specific listener mechanism for dynamic dark mode updates in FB4A. It builds on the OSS changes in D88427482 which added the `addListener()` API to `OverrideColorScheme` interface. **Why this is needed:** Previously, when users toggled dark mode in FB4A Settings, React Native JavaScript would not be notified of the change. The `AppearanceModule` would only reflect the initial color scheme state from instantiation, causing UI inconsistencies when users changed their theme preference in native settings UI. **How it works:** 1. User toggles dark mode in FB4A Settings → `ThemePreferences.setDarkMode()` is called 2. `ThemePreferences` notifies all registered listeners (including `FB4AThemeOverrideColorScheme`) 3. `FB4AThemeOverrideColorScheme` forwards the notification to `AppearanceModule` via the listener callback 4. `AppearanceModule.onConfigurationChanged()` is invoked (set up in OSS changes) 5. If the color scheme changed, an `appearanceChanged` event is emitted to React Native JavaScript Reviewed By: xiphirx Differential Revision: D88431860
meta-cla
bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88431860. |
Member
|
Closed internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change implements the internal Facebook-specific listener mechanism for dynamic dark mode updates in FB4A. It builds on the OSS changes in D88427482 which added the
addListener()API toOverrideColorSchemeinterface.Why this is needed:
Previously, when users toggled dark mode in FB4A Settings, React Native JavaScript would not be notified of the change. The
AppearanceModulewould only reflect the initial color scheme state from instantiation, causing UI inconsistencies when users changed their theme preference in native settings UI.How it works:
ThemePreferences.setDarkMode()is calledThemePreferencesnotifies all registered listeners (includingFB4AThemeOverrideColorScheme)FB4AThemeOverrideColorSchemeforwards the notification toAppearanceModulevia the listener callbackAppearanceModule.onConfigurationChanged()is invoked (set up in OSS changes)appearanceChangedevent is emitted to React Native JavaScriptReviewed By: xiphirx
Differential Revision: D88431860