Refactor how we promote shadow tree revisions as latest for JS consistency #54833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D88151490
branch
from
6394a36 to
17a5625
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 11, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 11, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
force-pushed
the
export-D88151490
branch
2 times, most recently
from
4d6137f to
bff42c4
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
force-pushed
the
export-D88151490
branch
from
bff42c4 to
87c4d40
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
force-pushed
the
export-D88151490
branch
2 times, most recently
from
33815fd to
855704c
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 15, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 16, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
force-pushed
the
export-D88151490
branch
2 times, most recently
from
4a8d4a0 to
8ee667b
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 17, 2025
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
…tency (facebook#54833) Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
j-piasecki
force-pushed
the
export-D88151490
branch
from
8ee667b to
147b6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency
Changes
LazyShadowTreeRevisionConsistencyManager::updateCurrentRevisionto pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter.This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists.
Differential Revision: D88151490