Add SurfaceHandlerCommitHook responsible for preserving layout constraints #54836
+704
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88839901. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 11, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
627e3c3 to
7661f9a
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 11, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
7661f9a to
c9d210c
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
c9d210c to
40a5dca
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
40a5dca to
161cd89
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
161cd89 to
c80d7ff
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
c80d7ff to
08ce2f1
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
08ce2f1 to
67a6f4f
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
67a6f4f to
9a51803
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
9a51803 to
b8f9a6c
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 15, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
b8f9a6c to
9265caf
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 15, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
9265caf to
333d0f0
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 16, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
333d0f0 to
695cfbc
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 16, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
695cfbc to
8474aa0
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 17, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
8474aa0 to
489e98f
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 17, 2025
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
489e98f to
e8b6630
Compare
…tency Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
Summary: Changelog: [Internal] Adds a feature flag for the Fabric commit branching mechanism. Differential Revision: D88151491
Summary: Changelog: [General][Changed] - Changed how React changes are commited to the Shadow Tree (behind a feature flag) Introduces two branches for the Shadow Tree commits - React always commits to the JS revision, while other sources should commit to the main revision. Commits to the JS revision schedule a "merge" commit at the end of the event loop pass to upstream the React changes to the main revision. "Merge" means taking the JS revision and promoting it to become the new main, losing changes that happened between fork and merge. Preservation of these changes is the responsibility of the party that created them, and they should be reapplied using a commit hook. Differential Revision: D88151489
Summary: Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Differential Revision: D88736123
…aints (facebook#54836) Summary: Pull Request resolved: facebook#54836 Changelog: [General][Added] Added a `SurfaceHandlerCommitHook` to preserve layout constraints during commits from different threads Since layout constraints and layout context are being kept in the props of the `RootShadowNode`, it was possible for the JS revision merge to lose an update if it was being commited concurrently. `SurfaceHandlerCommitHook` fixes this by ensuring that the root node always uses the latest context and constraints. Differential Revision: D88839901
j-piasecki
force-pushed
the
export-D88839901
branch
from
e8b6630 to
67792be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Added] Added a
SurfaceHandlerCommitHookto preserve layout constraints during commits from different threadsSince layout constraints and layout context are being kept in the props of the
RootShadowNode, it was possible for the JS revision merge to lose an update if it was being commited concurrently.SurfaceHandlerCommitHookfixes this by ensuring that the root node always uses the latest context and constraints.Differential Revision: D88839901