Schedule JS revision merge on the main thread #54837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88736123. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 11, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
54c80f4 to
3f1af40
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 11, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
3f1af40 to
8c63e07
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
8c63e07 to
60bacda
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
60bacda to
14e6bfd
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
2 times, most recently
from
8d46ac4 to
c41db2b
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 12, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
c41db2b to
36f8f94
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
36f8f94 to
cbc886d
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
cbc886d to
be779da
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 16, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
be779da to
770a70f
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 17, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
2 times, most recently
from
a6bf104 to
1e9e96d
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Dec 17, 2025
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
…tency Summary: Changelog: [General][Changed] - Refactor how shadow tree revisions are promoted as latest for JS consistency Changes `LazyShadowTreeRevisionConsistencyManager::updateCurrentRevision` to pull the latest commited revision for a given surface id instead of accepting the new revision as a parameter. This way, the new revision is read from the same place for every update, which opens up the way to implement commit branching. This change will allow to always read from the JS tree revision, if it exists. Differential Revision: D88151490
Summary: Changelog: [Internal] Adds a feature flag for the Fabric commit branching mechanism. Differential Revision: D88151491
Summary: Changelog: [General][Changed] - Changed how React changes are commited to the Shadow Tree (behind a feature flag) Introduces two branches for the Shadow Tree commits - React always commits to the JS revision, while other sources should commit to the main revision. Commits to the JS revision schedule a "merge" commit at the end of the event loop pass to upstream the React changes to the main revision. "Merge" means taking the JS revision and promoting it to become the new main, losing changes that happened between fork and merge. Preservation of these changes is the responsibility of the party that created them, and they should be reapplied using a commit hook. Differential Revision: D88151489
Summary: Pull Request resolved: facebook#54837 Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread. Differential Revision: D88736123
j-piasecki
force-pushed
the
export-D88736123
branch
from
1e9e96d to
9e0a45f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Changed] - The JS revision merge now is scheduled on the main thread
Changes the Shadow Tree branching to schedule JS revision merge on the main thread instead of running it immediately at the end of the event loop. This will prevent shadow tree exhaustion when committing to the main branch, since all commits there will be happening on the same thread.
Differential Revision: D88736123