[ios][precompile] refactor header files generator for prebuilt React framework #54841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to change the target xcconfig from within `add_rn_core`, we need to make sure it is not overwritten by the line that sets the config. This commit fixes this by moving it after the line: `spec.pod_target_xcconfig = current_config`
A small cleanup to make the directory structure of the header file template when building xcframeworks. Umbrella and module map templates are now moved into templates folder.
To make the later VFS overlays work, our React umbrella header needs to use angled import syntax instead of quoted". This is so that the compiler will look up by module and not only by path.
Replace the regex-based approach for parsing podspec files with a declarative configuration system for header file collection: Add headers-config.js with explicit podspec configurations defining header patterns, directories, and subspecs - Add vfs.js to generate VFS overlay YAML files for Clang virtual file system support - Refactor headers.js to use the new configuration-based approach with support for nested subspecs and path preservation - Update xcframework.js to handle the new header mapping structure with source/target paths - This provides more reliable and maintainable header file collection for XCFramework builds by avoiding fragile regex parsing of Ruby podspec files.
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
Job Summary for GradleTest All :: run_fantom_tests
|
cipolleschi
requested changes
Dec 10, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
See my comment below. There are also some warnings on redeclared variables and variables declared but not used, so perhaps this PR requires a bit of work yet?
| */ | ||
|
|
||
| // Remember that our GLOB library doesn't like {h} in its patterns, so we use **/*.h instead of **/*.{h} | ||
| const PodSpecConfigurations /*: {[key: string]: PodSpecConfiguration} */ = { |
Contributor
There was a problem hiding this comment.
not really a fan that we have to maintain this manually, to be fair...
Can't we have a script that generates this file by globbing all the podspecs we have in the framework?
I also know that the pod command has an option to output the json representation of a .podspec file. Perhaps we can use that instead.
Collaborator
Author
There was a problem hiding this comment.
Rewrote it to read podspec_sources from all podspec files and exclude files - and then for the header-configs.js to contain a list of exception configuration for those pod specs that contains programmatically generated lists of exclude files, sources or specs.
Outputs exactly the same list of header files as the first iteration.
Now it reads from podspec files, except for some special cases that we have in the config file. Updated RCTSwiftUIWrapper.podspec to use podspec_sources (which we use to detect source) I tested this against the header files I got with the previous iteration, and also with the ones installed by Cocoapods.
Job Summary for GradleTest All :: run_fantom_tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the regex-based approach for parsing podspec files with a declarative configuration system for header file collection:
Add headers-config.js with explicit podspec configurations defining header patterns, directories, and subspecs
Changelog:
[IOS] [FIXED] - refactored header files generator for prebuilt React framework
Test Plan:
Run RNTester with prebuilt