fix(install): send stable per-run id (iid) with telemetry pings#44
Merged
Conversation
Mint one INSTALL_ID per run and pass it as &iid= on both install_started and install_complete pings, so the two events from a single install share identity server-side and can be joined into an install-reliability funnel. Previously each ping got a fresh random distinct_id, making them unjoinable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Clears CVE-2026-52870, CVE-2026-52869, CVE-2026-59950 flagged by pip-audit in the mcp framework (pulled transitively via fastmcp). Lockfile-only bump; fastmcp>=3.2 already permits 1.28.1, so no pyproject change. Full suite green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The installer's
install_startedandinstall_completepings each hitfadelab.net/api/ping, which minted a freshcli-${Date.now()}distinct_id per request — so the two events from one install never shared identity and couldn't be joined into a funnel.This mints one
INSTALL_IDper run (uuidgen, with a portable fallback) and passes it as&iid=on both pings. The server side (fadelab.netapi/ping.ts) already ships the matching change to useiidas the PostHogdistinct_id, falling back to the old scheme for older clients.Effect
install_started → install_completebecomes a real person-funnel (true install-reliability rate). Backward-compatible: old clients omitiidand keep working (just unjoinable, as before). Clean funnel data starts from deploy.Notes
PHANTOM_NO_TELEMETRY=1unchanged.🤖 Generated with Claude Code