Skip to content

refactor: switch admin create_queue from protobuf to binary encoding#8

Merged
vieiralucas merged 1 commit intomainfrom
refactor/binary-admin-encoding
Mar 27, 2026
Merged

refactor: switch admin create_queue from protobuf to binary encoding#8
vieiralucas merged 1 commit intomainfrom
refactor/binary-admin-encoding

Conversation

@vieiralucas
Copy link
Copy Markdown
Member

@vieiralucas vieiralucas commented Mar 27, 2026

Summary

  • Update test helper create_queue from hand-encoded protobuf to binary wire format
  • New binary_encode_create_queue method uses queue_len:u16 + queue + on_enqueue_len:u16 + on_failure_len:u16 + visibility_timeout_ms:u32

Test plan

  • Existing tests pass against a FIBP server with binary admin encoding (PR #153)
  • No protobuf encoding remains in test infrastructure

Summary by cubic

Switch the admin CreateQueue test helper from protobuf to the binary wire format to match the server’s admin protocol. This removes protobuf-specific logic and keeps tests compatible with binary admin servers.

  • Refactors
    • Added binary_encode_create_queue using: queue_len:u16 + queue:utf8 + on_enqueue_len:u16 + on_enqueue:utf8 + on_failure_len:u16 + on_failure:utf8 + visibility_timeout_ms:u32.
    • Replaced proto_encode_create_queue usage and removed the method.
    • UTF‑8 queue name with no 127‑byte limit; on_enqueue/on_failure set empty; visibility_timeout_ms set to 0.

Written for commit 5048cf8. Summary will update on new commits.

test helper now uses binary wire format for create_queue admin operation
(queue_len:u16 + queue + on_enqueue_len:u16 + on_failure_len:u16 +
visibility_timeout_ms:u32) instead of hand-encoded protobuf.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@vieiralucas vieiralucas merged commit f471981 into main Mar 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant