Skip to content

fix(Relay State): Use relay state param for redirection after login#118

Open
ghost wants to merge 2 commits into
fangli:masterfrom
goakshit:master
Open

fix(Relay State): Use relay state param for redirection after login#118
ghost wants to merge 2 commits into
fangli:masterfrom
goakshit:master

Conversation

@ghost

@ghost ghost commented Oct 1, 2019

Copy link
Copy Markdown

Overview

Pass next_url as relay param to prepare_to_authenticate which is echoed back as IDP response and can be accessed in POST request from IDP along with SAML RESPONSE.

Assign next url to relay state param if defined else consider previous next_url var

@cguethle

cguethle commented Oct 2, 2019

Copy link
Copy Markdown

Much better than my solution. Hopefully @fangli merges this and publishes a new patch version.

@ntravis

ntravis commented Oct 24, 2019

Copy link
Copy Markdown

We're also being hit by this, and would be quite happy to see it get merged in! @fangli do you have any objections to this as a fix to behavior?

@ntravis

ntravis commented Jan 1, 2020

Copy link
Copy Markdown

@fangli any reason not to merge?

@ecararus

ecararus commented Apr 8, 2020

Copy link
Copy Markdown

Hello Amit
Can this issue be closed?

@amitdctm

amitdctm commented Apr 8, 2020

Copy link
Copy Markdown

Hello Amit
Can this issue be closed?

Yes @ecararus. Awaiting @fangli to merge the same. :)

nickdnickd added a commit to nickdnickd/django-saml2-auth that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants