Add option to open main window on tray left click#4123
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
感谢这个 PR,实现得很完整——跨平台 不过经过考虑,这次我们倾向于不合并,主要是想克制设置项的数量:
为了保持设置页面简洁、避免选项膨胀,这次先不收。如果之后看到较多用户需要类似交互,我们更倾向于用"按平台给出合理默认值、而不暴露开关"的方式来实现。 再次感谢你的贡献,也欢迎以后继续提 PR 🙏 Thanks for the PR — it's nicely done: cross-platform After some thought, we've decided not to merge this one, mainly to keep the number of settings in check:
To keep the settings page simple and avoid preference creep, we'll pass on this for now. If we see more demand for this kind of interaction later, we'd prefer to implement it via sensible per-platform defaults rather than exposing a toggle. Thanks again for contributing — PRs are always welcome 🙏 |
Summary / 概述
添加选项以在托盘上打开主窗口左键单击
Screenshots / 截图
Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查(如修改了 Rust 代码)