Skip to content

Add option to open main window on tray left click#4123

Closed
iAJue wants to merge 1 commit into
farion1231:mainfrom
iAJue:main
Closed

Add option to open main window on tray left click#4123
iAJue wants to merge 1 commit into
farion1231:mainfrom
iAJue:main

Conversation

@iAJue

@iAJue iAJue commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary / 概述

添加选项以在托盘上打开主窗口左键单击

Screenshots / 截图

QQ_1781253603783

Checklist / 检查清单

  • pnpm typecheck passes / 通过 TypeScript 类型检查
  • pnpm format:check passes / 通过代码格式检查
  • cargo clippy passes (if Rust code changed) / 通过 Clippy 检查(如修改了 Rust 代码)
  • Updated i18n files if user-facing text changed / 如修改了用户可见文本,已更新国际化文件

@farion1231

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: dc4429145c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@farion1231

Copy link
Copy Markdown
Owner

感谢这个 PR,实现得很完整——跨平台 cfg 分支、四语 i18n、前后端类型都做齐了,看得出是花了心思的。

不过经过考虑,这次我们倾向于不合并,主要是想克制设置项的数量:

  • 这个功能的受众较窄,省下的也只是一次点击;
  • cc-switch 的核心操作是切换供应商,而这在托盘菜单里左键点开就能直接完成,通常并不需要打开主窗口;
  • 托盘菜单里已经有"显示主界面"入口,路径是可达的。

为了保持设置页面简洁、避免选项膨胀,这次先不收。如果之后看到较多用户需要类似交互,我们更倾向于用"按平台给出合理默认值、而不暴露开关"的方式来实现。

再次感谢你的贡献,也欢迎以后继续提 PR 🙏


Thanks for the PR — it's nicely done: cross-platform cfg handling, all four locales, and matching front/back-end types. Clearly a careful effort.

After some thought, we've decided not to merge this one, mainly to keep the number of settings in check:

  • The audience is fairly narrow, and it only saves a single click;
  • cc-switch's core action is switching providers, which can be done directly from the tray menu on left-click — opening the main window usually isn't needed;
  • The tray menu already has a "Show main window" entry, so the path already exists.

To keep the settings page simple and avoid preference creep, we'll pass on this for now. If we see more demand for this kind of interaction later, we'd prefer to implement it via sensible per-platform defaults rather than exposing a toggle.

Thanks again for contributing — PRs are always welcome 🙏

@farion1231 farion1231 closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants