-
-
Notifications
You must be signed in to change notification settings - Fork 70
fix: Fix Orama search not working on /docs #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Eomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know the offending issue?
Why do we need a wrapper now?
The issue is that the Orama plugin assumes |
|
@Eomm I've reworked this. This fix is much better now. Tested locally as much as possible. |
Description
/docsbecause the Orama Docusaurus plugin passed the Docusaurus v3 version object straight intosearchParams.where.version, which expects a string, so the filter never matched.@orama/plugin-docusaurus-v3, it assumesuseVersions()returns a string; Docusaurus v3 returns version objects.patch-packagediff to coerce the version object to its.name(with sensible fallbacks) before building the search filter. Addedpatch-package+postinstallto keep the patch applied, documented it inpatches/README.md, and removed the previous local SearchBar swizzle (initial fix version).Notes
Related Issues
#348
fastify/fastify#6390
Check List