-
Notifications
You must be signed in to change notification settings - Fork 71
CDTOOL-1260: Introduce 'service purge' command and 'purge' alias. #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| var c RootCommand | ||
| c.CmdClause = parent.Command(CommandName, "Invalidate objects in the Fastly cache") | ||
| // PurgeCommand calls the Fastly API to purge items from the cache. | ||
| type PurgeCommand struct { //revive:disable:exported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a new source file Revive complains about this structure name, but I've suppressed the warning since the code is not new, it was just relocated, and this naming is consistent with other existing commands.
719644e to
1166ccb
Compare
anthony-gomez-fastly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the 'service purge' command as a replacement for the 'purge' command. The 'purge' command is still available as an alias, but will issue a deprecation warning when it is used.
1166ccb to
3c6ad74
Compare
rcaril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid!
philippschulte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks!
Change summary
This PR adds the 'service purge' command as a replacement for the 'purge' command. The 'purge' command is still available as an alias, but will issue a deprecation warning when it is used.
This involved a number of changes:
structembedding to avoid duplicating any of the code from the `pkg/commands/service/purge' package. The alias command is 'unlisted' and issues a deprecation warning when it is used.This PR also fixes the
make fmttarget in theMakefileto work properly.All Submissions:
New Feature Submissions:
User Impact
New deprecation warning for the
purgecommand.