fix: apply clippy suggested fixes #2165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses clippy warnings across multiple crates by applying the suggested fixes:
AnalyticsPayload::new()tobuilder()to fixnew_ret_no_selfwarning (methods namednewshould returnSelf)TextTransformationandMdTransformationto fixtype_complexitywarnings#[allow(clippy::too_many_arguments)]to privateprocess_generationfunctionResult<_, ()>with customVadErrortype to fixresult_unit_errwarningfield_reassign_with_defaultwarningReview & Testing Checklist for Human
AnalyticsPayload::new()have been updated tobuilder()- grep the codebase to ensure no usages were missedVadErrortype change in vvad crate affects any callers ofpredict_16khz()outside the modified filescargo clippyon the affected packages to confirm warnings are resolvedRecommended test: Run
cargo clippy -p analytics -p buffer -p llama -p vvad -p whisper-local -p tauri-plugin-analytics -p tauri-plugin-windowsand verify no new warnings appear.Notes
too_many_argumentswarning in llama was suppressed rather than refactored since it's a private function and refactoring would be invasive