Skip to content

test: Add Feast Workbench Ray Compute engine and offline store test #5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntkathole merged 1 commit into from
Dec 22, 2025
Merged

test: Add Feast Workbench Ray Compute engine and offline store test #5778

ntkathole merged 1 commit into from
Dec 22, 2025

Conversation

@Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Dec 16, 2025 •
edited
Loading

What this PR does / why we need it:

  • Added Workbench Ray Compute engine and offline store test
  • Added kueue resources supported setup for ray cluster creation and feast_wb_ray_offline_store_test.go
  • Refactored Notebook setup methods to notebook-util to avoid duplicate code

Which issue(s) this PR fixes:

Misc

@Srihari1192 Srihari1192 force-pushed the addFeastRayTest branch 3 times, most recently from bff0cba to 7a8a448 Compare December 17, 2025 11:03
@Srihari1192 Srihari1192 marked this pull request as ready for review December 17, 2025 11:06
@Srihari1192 Srihari1192 requested a review from a team as a code owner December 17, 2025 11:06
@Srihari1192
Copy link
Contributor Author

Srihari1192 commented Dec 22, 2025

Tested using command go test -timeout 10m ./test/e2e_rhoai/ -v -ginkgo.focus=TestFeastRayOfflineStoreNotebook in local with latest workbench image, tests are looks good

ntkathole
ntkathole approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ntkathole ntkathole merged commit f2486a9 into feast-dev:master Dec 22, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Srihari1192 @ntkathole