Repository navigation
⚡ Bolt: remember item lambdas to prevent LazyColumn recompositions - #3
Conversation
Co-authored-by: felixbrucker <5189997+felixbrucker@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Coverage Report
|
💡 What: Remember lambda callbacks for items and cards in SleepTrackerScreen (SleepSessionItem, BedtimeReminderCard, HealthConnectSyncCard).
🎯 Why: When active sleep tracking is running, currentDurationMillis updates every second, causing SleepTrackerScreen to recompose. Unremembered lambdas created inside LazyColumn item scopes created new instances on every tick, causing every SleepSessionItem in the list to fail Compose skipping checks and recompose unnecessarily.
📊 Impact: Eliminates N unnecessary recompositions per second (where N is the number of recorded sleep sessions), saving CPU cycles and battery during active tracking.
🔬 Measurement: Verified with ./gradlew test and ./gradlew lint.
PR created automatically by Jules for task 1542351725572696274 started by @felixbrucker