fix: replace 2 bare except with except Exception in xeH.py

[KeloYuan]

Replaced bare except: with except Exception: to avoid catching KeyboardInterrupt/SystemExit.

[gemini-code-assist]

Code Review

This pull request replaces bare except clauses with except Exception in xeH.py to improve error handling. The review feedback identifies critical issues in the surrounding logic, including a NameError for an undefined variable and a logic error in a version check that would cause a KeyError. Additionally, it is recommended to log caught exceptions rather than swallowing them to facilitate debugging.

[gemini-code-assist]

While replacing the bare except is a good practice, the logic in the following else block (line 25) contains two significant issues that will cause the update process to fail:

1. NameError: SRC_UPDATE_VERSION is used but not defined in this scope. It should be const.SRC_UPDATE_VERSION.
2. Logic Error: The condition if 'v' not in r and r['v'] != SRC_UPDATE_VERSION: is incorrect. If 'v' is missing, it will raise a KeyError when attempting to access r['v']. If 'v' is present, the and will short-circuit and never check the version value. It should likely use or instead of and.

Since these issues lead to an exception that triggers the outer handler and deletes the update file, they should be addressed to make the update mechanism functional.

[gemini-code-assist]

Swallowing all exceptions silently here makes it difficult to debug issues with the update process, such as syntax errors in the downloaded code or a corrupted zip file. Consider logging the error or printing it to sys.stderr before proceeding with the cleanup.

        except Exception as e:
            sys.stderr.write("Failed to load update: %s\n" % e)

[Copilot]

Pull request overview

This PR updates the bootstrap updater loader (xeH.py) to avoid catching KeyboardInterrupt/SystemExit by replacing two bare except: blocks with except Exception:.

Changes:

• Replace bare except: with except Exception: when parsing info.json from src.zip.
• Replace bare except: with except Exception: around the update-load/reload sequence.

Comments suppressed due to low confidence (1)

xeH.py:26

• The version gate condition is currently if 'v' not in r and r['v'] != SRC_UPDATE_VERSION:. When 'v' is missing (the legacy case you’re trying to detect), Python will still evaluate r['v'] because the left side is True, raising a KeyError and skipping the intended legacy-handling path. This should be rewritten to avoid indexing r['v'] when the key is absent (likely using or, or r.get('v')).

                except Exception:
                    need_remove = True
                else:
                    if 'v' not in r and r['v'] != SRC_UPDATE_VERSION:
                        # ignoring legacy file

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.