NIP-59: prevent gift wrap events from being returned to non-recipients#138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIP-59 requires relays to guard access to kind 1059 (gift wrap) events. While the existing implementation already enforced this on the write path (allowing recipients to delete their gift wraps), it did not enforce it on the read path. Any client could query for gift wrap events without authentication.
This change applies the same access control pattern already used for kind 4 (Encrypted Direct Messages) to kind 1059: unauthenticated users receive a CLOSED message, and authenticated users can only query gift wraps addressed to themselves via the p tag filter.