-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(cli): add FRC-102 compatible EIP-191 signing via --fevm flag (#13256) #13388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(cli): add FRC-102 compatible EIP-191 signing via --fevm flag (#13256) #13388
Conversation
1178fb7 to
07c15b7
Compare
|
Hi all 👋 Just wanted to follow up on this PR. |
|
@hugomrdias @eshon @bumblefudge can you help us out here -- this PR does two things, it changes the default signature to be the version |
in this command we only care about 0x46 "personal_sign", filsnap and ledger only implement 0x46 for personal messages. yes, its a breaking change there no more unprefixed signatures exactly frc-0102 purpose https://github.com/hugomrdias/filecoin/blob/main/packages/iso-filecoin/src/wallet.js#L274-L285 |
Signed-off-by: Angelina <[email protected]>
OK, @aceppaluni would you mind please just removing the But then also, we need to fix the "verify" command to be the reverse of |
Signed-off-by: Angelina <[email protected]>
|
@aceppaluni : please fil any CI checks that are failing (e.g., gofmt) and then go ahead and mark "ready for review" (assuming other feedback has been incoporated). |
* op: all actor cmd support --actor * update changelog --------- Co-authored-by: root <[email protected]>
Signed-off-by: spuradage <[email protected]>
Chore: fix typos
Signed-off-by: wyrapeseed <[email protected]>
…13404) Signed-off-by: reddaisyy <[email protected]>
…ilecoin-project#13407) * fix(cli): add to lotus-miner init * chore: make docsgen-cli * chore: update CHANGELOG.md * chore: improve error message Co-authored-by: Rod Vagg <[email protected]> --------- Co-authored-by: Rod Vagg <[email protected]>
Signed-off-by: fengyuchuanshen <[email protected]>
…-yb-5 (filecoin-project#13418) build(deps): bump github.com/yugabyte/pgx/v5 Bumps [github.com/yugabyte/pgx/v5](https://github.com/yugabyte/pgx) from 5.5.3-yb-2 to 5.5.3-yb-5. - [Release notes](https://github.com/yugabyte/pgx/releases) - [Changelog](https://github.com/yugabyte/pgx/blob/master/CHANGELOG.md) - [Commits](yugabyte/pgx@v5.5.3-yb-2...v5.5.3-yb-5) --- updated-dependencies: - dependency-name: github.com/yugabyte/pgx/v5 dependency-version: 5.5.3-yb-5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…6.0 (filecoin-project#13417) Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.5.0 to 22.6.0. - [Release notes](https://github.com/coreos/go-systemd/releases) - [Commits](coreos/go-systemd@v22.5.0...v22.6.0) --- updated-dependencies: - dependency-name: github.com/coreos/go-systemd/v22 dependency-version: 22.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roject#13416) Bumps [golang.org/x/time](https://github.com/golang/time) from 0.12.0 to 0.14.0. - [Commits](golang/time@v0.12.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-version: 0.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lecoin-project#13414) Bumps [github.com/drand/go-clients](https://github.com/drand/go-clients) from 0.2.2 to 0.2.3. - [Commits](drand/go-clients@v0.2.2...v0.2.3) --- updated-dependencies: - dependency-name: github.com/drand/go-clients dependency-version: 0.2.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 0.10.0 in the multiformats group (filecoin-project#13412) build(deps): bump github.com/multiformats/go-multicodec Bumps the multiformats group with 1 update: [github.com/multiformats/go-multicodec](https://github.com/multiformats/go-multicodec). Updates `github.com/multiformats/go-multicodec` from 0.9.2 to 0.10.0 - [Release notes](https://github.com/multiformats/go-multicodec/releases) - [Commits](multiformats/go-multicodec@v0.9.2...v0.10.0) --- updated-dependencies: - dependency-name: github.com/multiformats/go-multicodec dependency-version: 0.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: multiformats ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0.35.1 in the libp2p-ecosystem group (filecoin-project#13411) build(deps): bump github.com/libp2p/go-libp2p-kad-dht Bumps the libp2p-ecosystem group with 1 update: [github.com/libp2p/go-libp2p-kad-dht](https://github.com/libp2p/go-libp2p-kad-dht). Updates `github.com/libp2p/go-libp2p-kad-dht` from 0.34.0 to 0.35.1 - [Release notes](https://github.com/libp2p/go-libp2p-kad-dht/releases) - [Commits](libp2p/go-libp2p-kad-dht@v0.34.0...v0.35.1) --- updated-dependencies: - dependency-name: github.com/libp2p/go-libp2p-kad-dht dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: libp2p-ecosystem ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o 0.9.0 in the filecoin-core group (filecoin-project#13409) build(deps): bump github.com/filecoin-project/go-jsonrpc Bumps the filecoin-core group with 1 update: [github.com/filecoin-project/go-jsonrpc](https://github.com/filecoin-project/go-jsonrpc). Updates `github.com/filecoin-project/go-jsonrpc` from 0.8.0 to 0.9.0 - [Release notes](https://github.com/filecoin-project/go-jsonrpc/releases) - [Commits](filecoin-project/go-jsonrpc@v0.8.0...v0.9.0) --- updated-dependencies: - dependency-name: github.com/filecoin-project/go-jsonrpc dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: filecoin-core ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
docs(documentation): Fix vendored link in documentation
Signed-off-by: efcking <[email protected]>
…ilecoin-project#13431) * chore: bump version to v1.34.3-dev chore: bump version to v1.34.3-dev * chore: update changelog in prep for v1.34.2 chore: update changelog in prep for v1.34.2 * fix: remove v-letter in version fix: remove v-letter in version
* docs: fix outdated link * up: CHANGELOG.md
…lecoin-project#13435) * fix(grammar): fix article mistakes in comments and error messages * fix(grammar): fix article mistakes in comments and error messages
Signed-off-by: bigmoonbit <[email protected]>
…lecoin-project#13441) fix: update Docker runtime base to ubuntu:22.04 for glibc compatibility fix: update Docker runtime base to ubuntu:22.04 for glibc compatibility
Signed-off-by: Angelina <[email protected]>
Signed-off-by: Angelina <[email protected]>
b7a7a9b to
70006d9
Compare
Related Issues
This PR aims to fix Issue #13256
Proposed Changes
This PR updates the
lotus wallet signcommand to implement FRC-102, allowing users to sign messages with an EIP-191 (Ethereum-style) prefix for FEVM compatibility.Additional Info
--fevmflag towallet signcommand.Checklist
Before you mark the PR ready for review, please make sure that: