test: look up alerts sensor entity id dynamically#141
Merged
Conversation
The configured-name change made the hard-coded sensor.nws_alerts_alerts literal unreliable. Discover the entity via the sensor domain instead so the test survives future entity_id format changes.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Reopening with better justification than the original description. I framed this as preemptive hardening against 7eda048, but that attribution was wrong. The configured-name change isn't actually what makes the hard-coded slug unreliable. The real situation: So the dynamic lookup here fixes a real, pre-existing bug in the test rather than a hypothetical future one, with zero user impact and no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The configured-name change made the hard-codedsensor.nws_alerts_alertsstring literal unreliable in pytest.EDIT: tests/test_sensor.py has asserted sensor.nws_alerts since a234bff (Aug 2024), and that slug has never matched a fresh install of this integration.
The proposed changes discover the entity via the sensor domain instead so the test survives future entity_id format changes.
Notes