Skip to content
This repository was archived by the owner on Sep 10, 2026. It is now read-only.

Increase WindowCloseWaitTimeout to 2 seconds - #269

Open
thorsent wants to merge 2 commits into
finos:mainfrom
thorsent:main
Open

Increase WindowCloseWaitTimeout to 2 seconds#269
thorsent wants to merge 2 commits into
finos:mainfrom
thorsent:main

Conversation

@thorsent

Copy link
Copy Markdown

The former timeout period of 1 second was not enough to guarantee that test windows were closed before the next test began (e.g. when running conformance tests in CI on slow VDIs).

@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 24, 2025

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

@kriswest kriswest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thorsent 👋

Seems fine to me.

Note this code also exists at https://github.com/finos/FDC3/blob/main/toolbox/fdc3-conformance/src/constants.ts

However, it looks like some past work on this framework was not merged back into it and @robmoffat has continued the development from an uncertain point (or perhaps with an uncertain number of past fixes that should have been merged back to main?) for the 2.2 changes:
image

I'm not sure what is being done to sort that out currently... Once done this project should be archived.

For now I would suggest also making this change at: https://github.com/finos/FDC3/blob/main/toolbox/fdc3-conformance/src/constants.ts

@thorsent

Copy link
Copy Markdown
Author

Thanks @kriswest , I wasn't aware the conformance tests had been consolidated into the fdc3 repo. I've pushed a PR with a corresponding change.

@robmoffat

Copy link
Copy Markdown
Member

I've raised #270

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants