XML disambiguation - #613
Open
SimonCockx wants to merge 8 commits into
Open
Conversation
SimonCockx
commented
May 26, 2026
| if (direct != null) { | ||
| return Optional.of(direct); | ||
| } | ||
| // 2. Walk declaring classes (handles generated nested builders/impls). |
SimonCockx
commented
May 26, 2026
| * builder type, plus the attribute value type. | ||
| */ | ||
| private static final class AttributeAccessor { | ||
| private static final Map<CacheKey, AttributeAccessor> CACHE = new HashMap<>(); |
Contributor
Author
There was a problem hiding this comment.
This seems to live forever. Potential memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and the issue/story number.
Type of change
Please delete options that are not relevant.