Skip to content

feat(firestore): add DML stages, literals source, and atomic execution option to iOS SDK pipelines #16500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wu-hui wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(firestore): add DML stages, literals source, and atomic execution option to iOS SDK pipelines #16500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54f611c
feat(firestore): add DML stages, literals source, and atomic executio…
wu-hui Aug 13, 2026
b72add6
feat(firestore): refine execute options and add comprehensive docstri…
wu-hui Aug 19, 2026
9efa421
feat(firestore): update proto for auto_commit_transaction and add ser…
wu-hui Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ endif()
# don't complain about doing so. Our dependencies aren't good about declaring
# BYPRODUCTS and we mix them all into a single superbuild so we can't enable
# this policy until all dependencies are capable of doing so.
if(POLICY CMP0058)
if(POLICY CMP0058 AND CMAKE_VERSION VERSION_LESS "4.0")
cmake_policy(SET CMP0058 OLD)
endif()

Expand Down
361 changes: 193 additions & 168 deletions Firestore/Protos/cpp/google/firestore/v1/firestore.pb.cc
View file
Open in desktop

Large diffs are not rendered by default.

37 changes: 36 additions & 1 deletion Firestore/Protos/cpp/google/firestore/v1/firestore.pb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4765,6 +4765,7 @@ class ExecutePipelineRequest final :

enum : int {
kDatabaseFieldNumber = 1,
kAutoCommitTransactionFieldNumber = 9,
kStructuredPipelineFieldNumber = 2,
kTransactionFieldNumber = 5,
kNewTransactionFieldNumber = 6,
Expand All @@ -4785,6 +4786,16 @@ class ExecutePipelineRequest final :
const std::string& value);
std::string* _internal_mutable_database();

public:
// bool auto_commit_transaction = 9 [(.google.api.field_behavior) = OPTIONAL];
void clear_auto_commit_transaction() ;
bool auto_commit_transaction() const;
void set_auto_commit_transaction(bool value);

private:
bool _internal_auto_commit_transaction() const;
void _internal_set_auto_commit_transaction(bool value);

public:
// .google.firestore.v1.StructuredPipeline structured_pipeline = 2;
bool has_structured_pipeline() const;
Expand Down Expand Up @@ -4880,7 +4891,7 @@ class ExecutePipelineRequest final :

friend class ::google::protobuf::internal::TcParser;
static const ::google::protobuf::internal::TcParseTable<
0, 5, 3,
0, 6, 3,
59, 2>
_table_;
friend class ::google::protobuf::MessageLite;
Expand All @@ -4898,6 +4909,7 @@ class ExecutePipelineRequest final :
inline explicit Impl_(::google::protobuf::internal::InternalVisibility visibility,
::google::protobuf::Arena* arena, const Impl_& from);
::google::protobuf::internal::ArenaStringPtr database_;
bool auto_commit_transaction_;
union PipelineTypeUnion {
constexpr PipelineTypeUnion() : _constinit_{} {}
::google::protobuf::internal::ConstantInitialized _constinit_;
Expand Down Expand Up @@ -11781,6 +11793,29 @@ inline ::google::protobuf::Timestamp* ExecutePipelineRequest::mutable_read_time(
return _msg;
}

// bool auto_commit_transaction = 9 [(.google.api.field_behavior) = OPTIONAL];
inline void ExecutePipelineRequest::clear_auto_commit_transaction() {
PROTOBUF_TSAN_WRITE(&_impl_._tsan_detect_race);
_impl_.auto_commit_transaction_ = false;
}
inline bool ExecutePipelineRequest::auto_commit_transaction() const {
// @@protoc_insertion_point(field_get:google.firestore.v1.ExecutePipelineRequest.auto_commit_transaction)
return _internal_auto_commit_transaction();
}
inline void ExecutePipelineRequest::set_auto_commit_transaction(bool value) {
_internal_set_auto_commit_transaction(value);
// @@protoc_insertion_point(field_set:google.firestore.v1.ExecutePipelineRequest.auto_commit_transaction)
}
inline bool ExecutePipelineRequest::_internal_auto_commit_transaction() const {
PROTOBUF_TSAN_READ(&_impl_._tsan_detect_race);
return _impl_.auto_commit_transaction_;
}
inline void ExecutePipelineRequest::_internal_set_auto_commit_transaction(bool value) {
PROTOBUF_TSAN_WRITE(&_impl_._tsan_detect_race);
;
_impl_.auto_commit_transaction_ = value;
}

inline bool ExecutePipelineRequest::has_pipeline_type() const {
return pipeline_type_case() != PIPELINE_TYPE_NOT_SET;
}
Expand Down
5 changes: 4 additions & 1 deletion Firestore/Protos/nanopb/google/firestore/v1/firestore.nanopb.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,13 @@ const pb_field_t google_firestore_v1_RunQueryResponse_fields[5] = {
PB_LAST_FIELD
};

const pb_field_t google_firestore_v1_ExecutePipelineRequest_fields[6] = {
const pb_field_t google_firestore_v1_ExecutePipelineRequest_fields[7] = {
PB_FIELD( 1, BYTES , SINGULAR, POINTER , FIRST, google_firestore_v1_ExecutePipelineRequest, database, database, 0),
PB_ONEOF_FIELD(pipeline_type, 2, MESSAGE , ONEOF, STATIC , OTHER, google_firestore_v1_ExecutePipelineRequest, structured_pipeline, database, &google_firestore_v1_StructuredPipeline_fields),
PB_ONEOF_FIELD(consistency_selector, 5, BYTES , ONEOF, POINTER , OTHER, google_firestore_v1_ExecutePipelineRequest, transaction, pipeline_type.structured_pipeline, 0),
PB_ONEOF_FIELD(consistency_selector, 6, MESSAGE , ONEOF, STATIC , UNION, google_firestore_v1_ExecutePipelineRequest, new_transaction, pipeline_type.structured_pipeline, &google_firestore_v1_TransactionOptions_fields),
PB_ONEOF_FIELD(consistency_selector, 7, MESSAGE , ONEOF, STATIC , UNION, google_firestore_v1_ExecutePipelineRequest, read_time, pipeline_type.structured_pipeline, &google_protobuf_Timestamp_fields),
PB_FIELD( 9, BOOL , SINGULAR, STATIC , OTHER, google_firestore_v1_ExecutePipelineRequest, auto_commit_transaction, consistency_selector.read_time, 0),
PB_LAST_FIELD
};

Expand Down Expand Up @@ -659,6 +660,8 @@ std::string google_firestore_v1_ExecutePipelineRequest::ToString(int indent) con
consistency_selector.read_time, indent + 1, true);
break;
}
tostring_result += PrintPrimitiveField("auto_commit_transaction: ",
auto_commit_transaction, indent + 1, false);

bool is_root = indent == 0;
if (!tostring_result.empty() || is_root) {
Expand Down
8 changes: 5 additions & 3 deletions Firestore/Protos/nanopb/google/firestore/v1/firestore.nanopb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ typedef struct _google_firestore_v1_ExecutePipelineRequest {
google_firestore_v1_TransactionOptions new_transaction;
google_protobuf_Timestamp read_time;
} consistency_selector;
bool auto_commit_transaction;

std::string ToString(int indent = 0) const;
/* @@protoc_insertion_point(struct:google_firestore_v1_ExecutePipelineRequest) */
Expand Down Expand Up @@ -459,7 +460,7 @@ typedef struct _google_firestore_v1_ListenRequest {
#define google_firestore_v1_RollbackRequest_init_default {NULL, NULL}
#define google_firestore_v1_RunQueryRequest_init_default {NULL, 0, {google_firestore_v1_StructuredQuery_init_default}, 0, {NULL}}
#define google_firestore_v1_RunQueryResponse_init_default {google_firestore_v1_Document_init_default, NULL, google_protobuf_Timestamp_init_default, 0}
#define google_firestore_v1_ExecutePipelineRequest_init_default {NULL, 0, {google_firestore_v1_StructuredPipeline_init_default}, 0, {NULL}}
#define google_firestore_v1_ExecutePipelineRequest_init_default {NULL, 0, {google_firestore_v1_StructuredPipeline_init_default}, 0, {NULL}, 0}
#define google_firestore_v1_ExecutePipelineResponse_init_default {NULL, 0, NULL, google_protobuf_Timestamp_init_default, google_firestore_v1_ExplainStats_init_default}
#define google_firestore_v1_RunAggregationQueryRequest_init_default {NULL, 0, {google_firestore_v1_StructuredAggregationQuery_init_default}, 0, {NULL}}
#define google_firestore_v1_RunAggregationQueryResponse_init_default {google_firestore_v1_AggregationResult_init_default, NULL, google_protobuf_Timestamp_init_default}
Expand Down Expand Up @@ -491,7 +492,7 @@ typedef struct _google_firestore_v1_ListenRequest {
#define google_firestore_v1_RollbackRequest_init_zero {NULL, NULL}
#define google_firestore_v1_RunQueryRequest_init_zero {NULL, 0, {google_firestore_v1_StructuredQuery_init_zero}, 0, {NULL}}
#define google_firestore_v1_RunQueryResponse_init_zero {google_firestore_v1_Document_init_zero, NULL, google_protobuf_Timestamp_init_zero, 0}
#define google_firestore_v1_ExecutePipelineRequest_init_zero {NULL, 0, {google_firestore_v1_StructuredPipeline_init_zero}, 0, {NULL}}
#define google_firestore_v1_ExecutePipelineRequest_init_zero {NULL, 0, {google_firestore_v1_StructuredPipeline_init_zero}, 0, {NULL}, 0}
#define google_firestore_v1_ExecutePipelineResponse_init_zero {NULL, 0, NULL, google_protobuf_Timestamp_init_zero, google_firestore_v1_ExplainStats_init_zero}
#define google_firestore_v1_RunAggregationQueryRequest_init_zero {NULL, 0, {google_firestore_v1_StructuredAggregationQuery_init_zero}, 0, {NULL}}
#define google_firestore_v1_RunAggregationQueryResponse_init_zero {google_firestore_v1_AggregationResult_init_zero, NULL, google_protobuf_Timestamp_init_zero}
Expand Down Expand Up @@ -556,6 +557,7 @@ typedef struct _google_firestore_v1_ListenRequest {
#define google_firestore_v1_ExecutePipelineRequest_new_transaction_tag 6
#define google_firestore_v1_ExecutePipelineRequest_read_time_tag 7
#define google_firestore_v1_ExecutePipelineRequest_database_tag 1
#define google_firestore_v1_ExecutePipelineRequest_auto_commit_transaction_tag 9
#define google_firestore_v1_ExecutePipelineResponse_transaction_tag 1
#define google_firestore_v1_ExecutePipelineResponse_results_tag 2
#define google_firestore_v1_ExecutePipelineResponse_execution_time_tag 3
Expand Down Expand Up @@ -643,7 +645,7 @@ extern const pb_field_t google_firestore_v1_CommitResponse_fields[3];
extern const pb_field_t google_firestore_v1_RollbackRequest_fields[3];
extern const pb_field_t google_firestore_v1_RunQueryRequest_fields[6];
extern const pb_field_t google_firestore_v1_RunQueryResponse_fields[5];
extern const pb_field_t google_firestore_v1_ExecutePipelineRequest_fields[6];
extern const pb_field_t google_firestore_v1_ExecutePipelineRequest_fields[7];
extern const pb_field_t google_firestore_v1_ExecutePipelineResponse_fields[5];
extern const pb_field_t google_firestore_v1_RunAggregationQueryRequest_fields[6];
extern const pb_field_t google_firestore_v1_RunAggregationQueryResponse_fields[4];
Expand Down
4 changes: 4 additions & 0 deletions Firestore/Protos/protos/google/firestore/v1/firestore.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,10 @@ message ExecutePipelineRequest {
// minute timestamp within the past 7 days.
google.protobuf.Timestamp read_time = 7;
}

// Automatically commits the transaction after the pipeline has been executed.
// Only permitted in combination with `transaction` or `new_transaction`.
bool auto_commit_transaction = 9 [(google.api.field_behavior) = OPTIONAL];
}

// The response for [Firestore.Execute][].
Expand Down
Loading
Loading