infra(zip): remove CocoaPods umbrella headers. - #16540
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Generated by 🚫 Danger |
Per b/549729366,
This removes the CocoaPods umbrella headers from the final zip artifact.
With the new zip builder rewrite, we'll no longer be using CocoaPods for building our zips. As a part of this process, we won't be generating the
<framework>-umbrella.hheaders that CocoaPods naturally generates.The removal of these umbrella headers is a breaking change. Although, the zip rewrite may not be done in time for the next breaking change release (Firebase 13). To avoid any breakages when it is released, this PR adds functionality to preemptively remove the CocoaPods umbrella headers. This way, our migration to the new zip builder won't have to worry about any breakage.
The changes in this PR can be split up into three work groups:
Firebase.humbrella header to no longer use the CocoaPods header, and instead just use the module's auto-generated-Swiftheader.-umbrella.hheaders from the final artifacts.FirebaseMessaging.h), or fallback to a clang umbrella directory syntax for libraries that don't expose an umbrella header (ie;umbrella ".").DO_NOT_MERGE=Still needs a changelog entry to convey the change. Also need to do further manual testing to ensure everything works as expected.