Skip to content

infra(zip): remove CocoaPods umbrella headers. - #16540

Draft
daymxn wants to merge 3 commits into
mainfrom
dlr/remove-cocoapods-umbrella-header
Draft

infra(zip): remove CocoaPods umbrella headers.#16540
daymxn wants to merge 3 commits into
mainfrom
dlr/remove-cocoapods-umbrella-header

Conversation

@daymxn

@daymxn daymxn commented Aug 20, 2026

Copy link
Copy Markdown
Member

Per b/549729366,

This removes the CocoaPods umbrella headers from the final zip artifact.

With the new zip builder rewrite, we'll no longer be using CocoaPods for building our zips. As a part of this process, we won't be generating the <framework>-umbrella.h headers that CocoaPods naturally generates.

The removal of these umbrella headers is a breaking change. Although, the zip rewrite may not be done in time for the next breaking change release (Firebase 13). To avoid any breakages when it is released, this PR adds functionality to preemptively remove the CocoaPods umbrella headers. This way, our migration to the new zip builder won't have to worry about any breakage.

The changes in this PR can be split up into three work groups:

  1. Update the Firebase.h umbrella header to no longer use the CocoaPods header, and instead just use the module's auto-generated -Swift header.
  2. Add a post-processing step to remove the (CocoaPods) -umbrella.h headers from the final artifacts.
  3. Update the module maps to use either the module's existing umbrella header (eg; FirebaseMessaging.h), or fallback to a clang umbrella directory syntax for libraries that don't expose an umbrella header (ie; umbrella ".").

DO_NOT_MERGE=Still needs a changelog entry to convey the change. Also need to do further manual testing to ensure everything works as expected.

@daymxn daymxn added this to the Firebase 13 milestone Aug 20, 2026
@daymxn daymxn self-assigned this Aug 20, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@danger-firebase-ios

Copy link
Copy Markdown
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant