Sync CLI skills to the catalog + init revamp (catalog installs, workflow picker, drop build skills) - #203
Sync CLI skills to the catalog + init revamp (catalog installs, workflow picker, drop build skills)#203chenxin-yan wants to merge 6 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/commands/init.ts">
<violation number="1" location="src/commands/init.ts:137">
P2: The retry hints in the new SkillSelection constants (lines 130/137) point at `firecrawl setup skills` and `firecrawl setup workflows`, but those setup subcommands still install from the old sources — `setup skills` uses SKILL_REPOS = firecrawl/cli + firecrawl/skills (which includes the build skills this PR removes from init) and `setup workflows` uses WORKFLOW_SKILL_REPOS = firecrawl/firecrawl-workflows rather than the catalog. So a retry after a failed `init` install installs a different skill set than init just tried (extra build skills / old workflow repo) and ignores the user's chosen subset. Align setup.ts's skills/workflows subcommands with the catalog name-based selection (or adjust the retry text) so the documented retry matches what init installs.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| repo: CATALOG_REPO, | ||
| skills: WORKFLOW_SKILLS, | ||
| label: 'firecrawl workflow skills', | ||
| retryCommand: 'firecrawl setup workflows', |
There was a problem hiding this comment.
P2: The retry hints in the new SkillSelection constants (lines 130/137) point at firecrawl setup skills and firecrawl setup workflows, but those setup subcommands still install from the old sources — setup skills uses SKILL_REPOS = firecrawl/cli + firecrawl/skills (which includes the build skills this PR removes from init) and setup workflows uses WORKFLOW_SKILL_REPOS = firecrawl/firecrawl-workflows rather than the catalog. So a retry after a failed init install installs a different skill set than init just tried (extra build skills / old workflow repo) and ignores the user's chosen subset. Align setup.ts's skills/workflows subcommands with the catalog name-based selection (or adjust the retry text) so the documented retry matches what init installs.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/commands/init.ts, line 137:
<comment>The retry hints in the new SkillSelection constants (lines 130/137) point at `firecrawl setup skills` and `firecrawl setup workflows`, but those setup subcommands still install from the old sources — `setup skills` uses SKILL_REPOS = firecrawl/cli + firecrawl/skills (which includes the build skills this PR removes from init) and `setup workflows` uses WORKFLOW_SKILL_REPOS = firecrawl/firecrawl-workflows rather than the catalog. So a retry after a failed `init` install installs a different skill set than init just tried (extra build skills / old workflow repo) and ignores the user's chosen subset. Align setup.ts's skills/workflows subcommands with the catalog name-based selection (or adjust the retry text) so the documented retry matches what init installs.</comment>
<file context>
@@ -110,16 +110,32 @@ export const TEMPLATES: TemplateEntry[] = [
+ repo: CATALOG_REPO,
+ skills: WORKFLOW_SKILLS,
+ label: 'firecrawl workflow skills',
+ retryCommand: 'firecrawl setup workflows',
+};
</file context>
Mirror skills/ into catalog skills/cli/ on every push, with a mirror banner README, no-op detection, and rebase-retry push via deploy key.
…p build skills Route all init skill installs through the firecrawl/skills catalog with name-based --skill selection so install volume accrues to catalog counters. Interactive init now offers a multi-select of the 16 workflow skills; build skills are no longer installed (they target SDK integration, not CLI users, and remain one command away). Promote npx skills add firecrawl/skills and the contributor routing rule in the README.
3d00a51 to
7ed745d
Compare
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
The init retry hints point at setup skills/workflows, but those still installed from the legacy repo list (including build skills init no longer installs). Share the catalog selections between init and setup so a retry reinstalls exactly what init attempted. Harden the sync workflow: least-privilege token, SHA-pinned checkout.
5986c5d to
d4937ef
Compare
They teach the firecrawl research and firecrawl developer CLI commands, so this repo is their code home. Authored here, mirrored to the catalog under skills/cli/, and included in the default init/setup CLI set.
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
|
Architecture update (pure catalog): the research/developer index skills now live here as CLI skills (they teach |
Review fixes for firecrawl#203: - setup's no-npx fallback called installSkillsNative(repo) without the name filter, installing the entire catalog (build skills included) instead of the selection every other install path uses - drop the nonexistent --skills-only CLI flag from the developer-index skill (skills="only" stays HTTP/MCP-only per cli-argv contract) - note that the workflow retry hint reinstalls all workflow skills, not the picked subset - fix 'sturctural' typo in the research-index skill
1 participant
Implements the cli-repo side of the skills-structure migration (phases 1 and 3).
CI: sync workflow
sync-catalog.yml: on push toskills/**, mirrorsskills/intofirecrawl/skillsunderskills/cli/— banner README, no-op detection, rebase-retry push, never force-push. Uses secretCATALOG_DEPLOY_KEY(already provisioned).firecrawl initrevampnpx skills add firecrawl/skills --skill <names>(name-based, layout-independent), so init's install volume accrues to catalog counters from day one. The native no-npx installer gained the same name filter and fails loudly on missing names.npx skills add firecrawl/skills, adds the contributor routing rule.Verification
tsc --noEmitclean, 415 tests pass (init tests updated to the new contract, including a regression check that nofirecrawl-build*skill is installed), prettier clean.skillsCLI v1.5.23 source thatadd --skillaccepts space-separated names.Release gate
Merge after firecrawl/skills#14, dispatch
sync-catalog.ymlonce, and only then publish to npm — the new init resolves skill names against the catalog, soskills/cli/must be populated first.