feat: extract markdown for PDF pages with password - #444
Open
aynugek wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
No issues found across 7 files
Shadow auto-approve: would auto-approve. Adds optional password support for extract_pages_markdown in Rust core and Python/Node bindings with a new integration test. Backward compatible, documented, and tested; no risky changes are visible, so auto-approval.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add password support to per-page Markdown extraction so encrypted PDFs can be processed. Previously,
extract_pages_markdownfailed on encrypted PDFs; now callers can pass a password or rely on an empty-password attempt. Wrong or missing passwords return an Encrypted error.API changes
extract_pages_markdown_with_password(path, pages, password)andextract_pages_markdown_mem_with_password(bytes, pages, password). Existing functions remain and delegate withNone.extract_pages_markdown(path, pages=None, password=None)andextract_pages_markdown_bytes(data, pages=None, password=None). Stubs and docs updated.extract_pages_markdown(buffer, pages?, password?)andextract_pages_markdown_async(buffer, pages?, password?). Optionalpassword; default tries empty password. Type definitions updated. No migration required; existing two-arg calls continue to work.Notes
PdfError::Encrypted(propagates to Python/Node).Written for commit 9b1ccac. Summary will update on new commits.