More Miscellaneous Issues/Corrections #63

From the testing branch I had the ideas below. I may continue to add until we merge the testing branch to dev. I would not change any of these yet unless you want me to do them on the testing branch, you on a branch off the testing branch, or either of us on a branch off dev after testing is merged with dev.

• In yprBH_func() and yprBH_SlotLL(), move recruitmentTL=NULL to after lhparms= and before loi=. [Note that I did this on the testing branch, just putting this here to make note of.]
• The output from yprBH_SlotLL() uses "Under", "In", and "Above" whereas the input arguments use "under", "in", and "above" (e.g., cfunder=). Note the capitalization differences. While minor, it may cause issues for some users (e.g., it took me a while to figure out what the issue was when making tests).
• I think I mentioned this before but maybe not (and if I did and you don't want to change, I won't mention it again). I think it is odd not to use "over" with "under", or "below" with "above".
• I think that the nAtXXX values in the output from yprBH_slot_func() should be moved forward to be at the end of the other nXXXX items. Maybe do the same with the output from yprBH_func() for congruency. This will require some modifications to the testthat tests.
• Error/Warning messages should be made congruent. For example, some are like "'recruimentTL' must be less than 'Linf'" and others are like "The recruitment total length in mm must be less than the asymptotic mean length". We should decide whether to be short and argument-based or long and descriptive-based. I prefer the former as it is easier for users to read, easier to test, and users should be aware of argument names and what they represent. Changing these will require changes to testthat tests.
• In genRecruits(), I would move simyears to the first argument and NOT give it a default value (I would force the user to make this the same as what they use in dpmBH_MinLL().
• In genRecruits(), I would replaces lines 50-51 with method <- match.arg(methd) and then also delete lines 92-93.