Skip to content

Update allowed notifications#75

Merged
roznawsk merged 1 commit intomainfrom
fce-3215-fix-allowed-notifications
Apr 27, 2026
Merged

Update allowed notifications#75
roznawsk merged 1 commit intomainfrom
fce-3215-fix-allowed-notifications

Conversation

@roznawsk
Copy link
Copy Markdown
Member

Description

Describe your changes.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link
Copy Markdown

linear Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates which server notifications are surfaced by the SDK, aligning ALLOWED_NOTIFICATIONS with newer proto message types and adding tests to ensure future proto changes require an explicit maintainer decision.

Changes:

  • Add ServerMessageChannelAdded/Removed and switch from deprecated ServerMessageStreamConnected/Disconnected to ServerMessageStreamerConnected/Disconnected in ALLOWED_NOTIFICATIONS.
  • Re-export the newly-allowed notification types from fishjam.events.
  • Add a regression test that asserts every ServerMessage.content oneof member is either allowed or explicitly ignored, and that allowed notifications are re-exported.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
tests/test_allowed_notifications.py Adds tests to enforce an explicit allow/ignore decision for new ServerMessage.content oneof members and verifies re-exports.
fishjam/events/allowed_notifications.py Updates the allowed notification set/type union to include channel events and streamer connect/disconnect events.
fishjam/events/__init__.py Re-exports the newly allowed proto message types via imports and __all__.
AGENTS.md Adds a short development workflow guideline document (TDD red/green/refactor).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roznawsk roznawsk requested a review from Karolk99 April 22, 2026 10:59
@roznawsk roznawsk merged commit 3605afe into main Apr 27, 2026
9 of 11 checks passed
@roznawsk roznawsk deleted the fce-3215-fix-allowed-notifications branch April 27, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants