Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates which server notifications are surfaced by the SDK, aligning ALLOWED_NOTIFICATIONS with newer proto message types and adding tests to ensure future proto changes require an explicit maintainer decision.
Changes:
- Add
ServerMessageChannelAdded/Removedand switch from deprecatedServerMessageStreamConnected/DisconnectedtoServerMessageStreamerConnected/DisconnectedinALLOWED_NOTIFICATIONS. - Re-export the newly-allowed notification types from
fishjam.events. - Add a regression test that asserts every
ServerMessage.contentoneof member is either allowed or explicitly ignored, and that allowed notifications are re-exported.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_allowed_notifications.py |
Adds tests to enforce an explicit allow/ignore decision for new ServerMessage.content oneof members and verifies re-exports. |
fishjam/events/allowed_notifications.py |
Updates the allowed notification set/type union to include channel events and streamer connect/disconnect events. |
fishjam/events/__init__.py |
Re-exports the newly allowed proto message types via imports and __all__. |
AGENTS.md |
Adds a short development workflow guideline document (TDD red/green/refactor). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Karolk99
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)