test(contrail-e2e): adopt post-PR30 spaces split + community integration#35
Merged
flo-bit merged 1 commit intoMay 4, 2026
Conversation
Bring the e2e suite back to green under the package split:
- makeSpacesConfig() wraps the old flat { type, serviceDid, resolver }
shape under authority / recordHost and generates a fresh signing key
per call. The config validator now requires spaces.authority whenever
community is set, so this is the minimum viable shape for any test
that uses spaces.
- setupCommunityContrail() wires the community module via
createCommunityIntegration({ db, config: resolveConfig(...) }) and
passes the result as communityIntegration to the Contrail constructor.
The community config field is now opaque to contrail core; routes are
registered through the integration option.
- 7 test files updated to use the helpers; 4 community tests pick up a
workspace dep on @atmo-dev/contrail-community.
35/35 e2e tests pass against devnet. No source-package changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the
apps/contrail-e2esuite back to green under the new package split. 35/35 tests pass against devnet, up from 5 failed / 23 skipped onfeat/another-big-refactoras-is.No source-package changes — only test fixtures + a workspace dep on
@atmo-dev/contrail-community.What broke (and why)
Two layers of test-side migration debt from the package split:
1.
spacesconfig shape (7 files)Old:
New (per
docs/06-spaces.md+ the new validator atcontrail-base/types.ts:395):The validator throws
Invalid config: \community` requires `spaces.authority`when this shape is missing. Even pure spaces tests fail:.space.createSpace` returned 404 because the route wasn't registered.2. Community integration wiring (4 files)
config.communityis now opaque to contrail core (community?: unknownonContrailConfig). Routes are registered through aCommunityIntegrationobject built viacreateCommunityIntegration({ db, config: resolveConfig(...) })and passed ascommunityIntegrationto theContrailconstructor — same pattern thecontrail-communityunit tests use.Test plan
pnpm install && pnpm buildcleancd apps/contrail-e2e && pnpm stack:uppnpm test:e2e→Test Files 10 passed (10) / Tests 35 passed (35)npx tsc --noEmitinapps/contrail-e2ecleanapps/contrail-e2e/andpnpm-lock.yaml