Add support for Lambda Expressions in JUEL and support resolving properties from records #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy tests for the Odysseus JUEL implementation from https://github.com/beckchr/juel Copy Tomcat EL implementation tests from https://github.com/apache/tomcat/tree/97f157af6d750a644a3d1c26e2d6af0d59d7b553/test/org/apache/el Implement some improvements for JUEL: * Support BigInteger literal - prior to this if a number larger than a long was used it would throw an exception during expression parsing * Support BigDecimal literal - prior to this if a number larger than a double would be used we would have an an infinite double, now it will use BigDecimal * Support using other quote escaping in string literal according to: https://jakarta.ee/specifications/expression-language/6.0/jakarta-expression-language-spec-6.0#literals. * `\` must be escaped as `\\` * `"` must be escaped as `\"` when the string is enclosed with `"` * `"` may be escaped as `\"` when the string is enclosed with `'` * `'` must be escaped as `\'` when the string is enclosed with `'` * `'` may be escaped as `\'` when the string is enclosed with `"` * Adjust Odysseus TypeConverter to coerce null to non primitive types according to the JUEL spec (https://jakarta.ee/specifications/expression-language/6.0/jakarta-expression-language-spec-6.0#type-conversion). This leads to the changes in `AstBinary`, `AstChoice` and `AstUnary` to use a primitive boolean class to do the binding. It is safe to do since the other place where we coerce values is the BeanELResolver, in which we only call the coercion with a null value for primitives
… support from from the Copy Tomcat EL MethodExpressionTest tests from https://github.com/apache/tomcat/tree/97f157af6d750a644a3d1c26e2d6af0d59d7b553/test/org/apache/el
…or Lambda Expressions * Add support for getting length of arrays * Add OptionalELResolver * Add RecordELResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from adding support for Lambda Expressions this PR improves our testability for our JUEL expressions.
Copy tests for the Odysseus JUEL implementation from https://github.com/beckchr/juel
Copy Tomcat EL implementation tests from https://github.com/apache/tomcat/tree/97f157af6d750a644a3d1c26e2d6af0d59d7b553/test/org/apache/el
Implement some improvements for JUEL:
\must be escaped as\\"must be escaped as\"when the string is enclosed with""may be escaped as\"when the string is enclosed with''must be escaped as\'when the string is enclosed with''may be escaped as\'when the string is enclosed with"This leads to the changes in
AstBinary,AstChoiceandAstUnaryto use a primitive boolean class to do the binding.It is safe to do since the other place where we coerce values is the BeanELResolver, in which we only call the coercion with a null value for primitives