Add a separate configuration option for auto creating a log group#254
Open
cristian-radu wants to merge 1 commit into
Open
Add a separate configuration option for auto creating a log group#254cristian-radu wants to merge 1 commit into
cristian-radu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like log streams are more dynamic in nature so creating them automatically makes a lot of sense to me.
For example, we use a separate log stream per EC2 instance. However, log groups are fairly static in my environment. We have one per application and would rather manage these through IaC tooling.
It came as a surprise to me that the auto_create_stream option also creates the log group since that is not what the name would suggest. (admittedly, I should have read the docs here more carefully)
I propose adding an "auto_create_group" option as a separate feature.
It may be a breaking change for some deployments, but feels like users should have the option to choose what logging components to auto-create.
Unit tests fail on ruby 2.5, but this is EOL so ignored them.
Not deployed this anywhere yet. Will test it when I get a chance.