Repository navigation
Update Presubmit check-run only if number of failed jobs changed. - #5169
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces tracking of whether the failed job count has changed (failedCountChanged) in PresubmitGuardConclusion and UnifiedCheckRun. This is used in Scheduler to conditionally trigger _requireActionForPresubmit only when the failed count changes, avoiding redundant updates. However, a critical issue was identified where the Presubmit check run can get stuck in the inProgress state indefinitely if a retried job succeeds but another job remains failed (meaning the failed count doesn't change, but there are no remaining jobs). It is recommended to update the condition to also trigger when there are no remaining jobs (stagingConclusion.remaining == 0).
ievdokdm
force-pushed
the
194455-presubmit-update
branch
from
October 30, 2026 20:31
c7fea7d to
c68a021
Compare
ievdokdm
force-pushed
the
194455-presubmit-update
branch
from
November 2, 2026 19:08
c68a021 to
1d563b2
Compare
ievdokdm
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: flutter/flutter#194455
Previously, once a job failed, every subsequent build event triggered a redundant GitHub API call to update the
Presubmitcheck run even when the job succeeded.Since we display a list of failed jobs in a
Presubmitcheck run description we still have to update it every time new job failed or failed job re-run.Added
failedCountChangedtoPresubmitGuardConclusion(set inUnifiedCheckRun.markConclusion) and updatedScheduler.processBuildCompletedto only update thePresubmitcheck run when the number of failed jobs changes.