Repository navigation
Update local flow imports before VS Code file and folder moves - #276
Open
JoaquinBatser wants to merge 2 commits into
Open
JoaquinBatser wants to merge 2 commits into
JoaquinBatser wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving a flow or its imported file leaves relative paths pointing to the old location. Handle VS Code's
onWillRenameFilesevent and return a workspace edit before the move. The import rewriter changes only YAML scalar ranges, preserving comments, formatting, and unsaved document edits.This covers moved files and folders, simultaneous moves, nested inline nodes, legacy import maps, and code-node file imports. Package references and unrelated configuration remain untouched. Moves performed outside VS Code's rename event are outside this change's scope.
Closes #112.
/claim #112
Short demonstration: rendered transcript of an actual VS Code 1.98.2 integration run showing the dirty document before and after a file rename. This is execution output, not a screen recording.
Validation on Windows:
pnpm install --frozen-lockfile --offlinepassed after adding the already-locked YAML dependency to the extension.pnpm buildis blocked on this Windows environment by the existingrm -rf distcommand incore/package.json('rm' is not recognized). The full monorepo test suite was not run; the checks above are focused checks, not a claim that the full build is green.The pure tests can run with
pnpm --filter flyde-vscode exec mocha --ui tdd --require ts-node/register src/test/importEdits.test.ts. The VS Code test runner discovers the new integration test alongside existing tests after compilation.This contribution was developed with AI assistance.