Repository navigation
Conversation
Refs flydelabs#112 Bounty-Artifact: 6e7ab487d9b23f2a60a959382a08082784cf7be14c22223c9f3ecc2aa83ecb36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #112.
Summary
Update local flow references when imported files or folders move, and rebase imports when their importing flow moves. Preserve unsaved document changes and report rejected VS Code edits. Full pnpm build and all 17 VS Code host tests passed, including the reproduced-and-fixed applyEdit(false) failure. Stored visual baselines fail identically on the unmodified base and this patch; all 4 actual screenshots are byte-identical, so no patch visual regression was detected. Stored-baseline visual tests remain failed.
Acceptance coverage
AI-reviewed mapping to the source and executed checks:
vscode/src/test/updateFlowReferencesOnRename.test.tsvscode/src/test/updateFlowReferencesOnRename.test.tsScope
5 files, +400/-0 lines; 1 test files; moderate diff
Changed files
loader/src/serdes/index.tsloader/src/serdes/updateFlowReferencesOnRename.tsvscode/src/extension.tsvscode/src/test/updateFlowReferencesOnRename.test.tsvscode/src/updateFlowReferencesOnRename.tsVerification
pnpm --filter flyde-vscode... build: PASSpnpm test: PASSTests ran in a credential-free, network-isolated Linux sandbox. A separate AI review session accepted the tested diff.
AI-assisted contribution under a human-operated account; this is not a claim that a person has manually reviewed every line.
/claim #112