Repository navigation
Conversation
A connected peer can send a VF4 card event with an arbitrary player number. The handler used it to index beyond the global MapleDevices array. Require a complete card event and restrict the player number to the two players supported by the GGPO session.
Press5elect
pushed a commit
to Press5elect/PSFlycast
that referenced
this pull request
Oct 7, 2026
…ast's open pull requests, release candidates in the updater, no Screenshot control - Netplay: the checksum of a save state or of a CDI, GDI or CUE image is the file's, not its pointer's (flyinghead#2513). - sh4: the FPSCR cause field is cleared when the guest writes FPSCR (flyinghead#2531). - CHD: the track metadata's text fields are held to their buffers (flyinghead#2384). - Input: absolute mouse motion rebased after relative input (flyinghead#2528); axis detection for triggers that report as buttons (flyinghead#2213). - Checks of an ISO9660 directory record, RZIP chunk sizes, DNS answers, GGPO input packets and card events, and a Naomi LST's ranges (flyinghead#2414, flyinghead#2415, flyinghead#2416, flyinghead#2519, flyinghead#2520, flyinghead#2521). - The updater ranks v1.1.0-rc1 under v1.1.0, and a release's build is not offered candidates. - The quick menu's Screenshot row and control are gone: the console's Create button takes screenshots. - Built with PS5_Vulkan 5b5e4fc, the payload SDK fork at b5efad5 and libsmb2 7e4ff97. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connected GGPO peer can send a VF4 card application message with an arbitrary player number.
on_messagecurrently passes it directly to:setRfidCardData(event->u.card.playerNum, event->u.card.data);setRfidCardDatathen accesses:MapleDeviceshas four rows, so a player number of 255 attempts to access row 256. This invalidshared_ptraccess can crash or corrupt the online session. The handler also does not ensure the message contains a complete card event.Require the exact VF4 card-event length and restrict the player number to the two players supported by the GGPO session. Flycast’s sender already uses only player zero or one.